Switch deploy to the active-app-version classification#8056
Open
isaacroldan wants to merge 1 commit into
Open
Conversation
github-actions
Bot
added
the
no-changelog
Contributor
Author
|
Warning This pull request is not mergeable via GitHub because a downstack PR is open. Once all requirements are satisfied, merge this PR as a stack on Graphite.
This stack of pull requests is managed by Graphite. Learn more about stacking. |
This was referenced Jul 10, 2026
isaacroldan
force-pushed
the
deploy-split/05b-deploy-app-version-module
branch
from
adc37e4 to
838bb7e
Compare
isaacroldan
force-pushed
the
deploy-split/05c-switch-deploy
branch
from
d8abcc9 to
6819f61
Compare
isaacroldan
force-pushed
the
deploy-split/05b-deploy-app-version-module
branch
from
838bb7e to
146fd63
Compare
isaacroldan
force-pushed
the
deploy-split/05c-switch-deploy
branch
from
6819f61 to
7a73d6c
Compare
isaacroldan
force-pushed
the
deploy-split/05b-deploy-app-version-module
branch
from
146fd63 to
9ce00c5
Compare
isaacroldan
force-pushed
the
deploy-split/05c-switch-deploy
branch
from
7a73d6c to
346a29f
Compare
isaacroldan
force-pushed
the
deploy-split/05b-deploy-app-version-module
branch
from
9ce00c5 to
aefc40d
Compare
isaacroldan
force-pushed
the
deploy-split/05c-switch-deploy
branch
from
346a29f to
3036c8c
Compare
isaacroldan
force-pushed
the
deploy-split/05b-deploy-app-version-module
branch
from
aefc40d to
03fa20e
Compare
isaacroldan
force-pushed
the
deploy-split/05c-switch-deploy
branch
2 times, most recently
from
644c235 to
3260c7b
Compare
isaacroldan
force-pushed
the
deploy-split/05b-deploy-app-version-module
branch
2 times, most recently
from
2a3ef5e to
9cee8ca
Compare
isaacroldan
force-pushed
the
deploy-split/05c-switch-deploy
branch
2 times, most recently
from
c283e20 to
8876f69
Compare
isaacroldan
force-pushed
the
deploy-split/05b-deploy-app-version-module
branch
from
9cee8ca to
8580282
Compare
4 tasks
isaacroldan
force-pushed
the
deploy-split/05b-deploy-app-version-module
branch
from
8580282 to
8161f82
Compare
isaacroldan
force-pushed
the
deploy-split/05c-switch-deploy
branch
from
8876f69 to
8c9c96f
Compare
isaacroldan
force-pushed
the
deploy-split/05c-switch-deploy
branch
from
8c9c96f to
6f5abbc
Compare
isaacroldan
force-pushed
the
deploy-split/05b-deploy-app-version-module
branch
from
8161f82 to
50f3d2c
Compare
isaacroldan
force-pushed
the
deploy-split/05c-switch-deploy
branch
from
6f5abbc to
c583dc4
Compare
isaacroldan
force-pushed
the
deploy-split/05b-deploy-app-version-module
branch
2 times, most recently
from
dddc498 to
a63ce6f
Compare
isaacroldan
force-pushed
the
deploy-split/05c-switch-deploy
branch
from
c583dc4 to
2991088
Compare
Contributor
Differences in type declarationsWe detected differences in the type declarations generated by Typescript for this branch compared to the baseline ('main' branch). Please, review them to ensure they are backward-compatible. Here are some important things to keep in mind:
New type declarationsWe found no new type declarations in this PR Existing type declarationspackages/cli-kit/dist/public/common/version.d.ts@@ -1 +1 @@
-export declare const CLI_KIT_VERSION = "4.5.0";
\ No newline at end of file
+export declare const CLI_KIT_VERSION = "4.4.0";
\ No newline at end of file
|
Wires `deploy` to the new module: `ensureDeployContext` calls `ensureDeployIdentifiersFromAppVersion` and returns `DeployIdentifiers`, the bundle/upload path consumes the resulting maps (upload's `extensionIds` becomes `appModuleRegistrationIds`), and `deploy` no longer writes identifiers back to the .env file. The interactive matching flow is now unused; it is removed in the next commit. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
isaacroldan
force-pushed
the
deploy-split/05c-switch-deploy
branch
2 times, most recently
from
2991088 to
9ea4edb
Compare
isaacroldan
force-pushed
the
deploy-split/05b-deploy-app-version-module
branch
from
a63ce6f to
dc6cfea
Compare
Contributor
Agree! The changeset is missing |
Contributor
Author
|
Actually, this wasn't happening anymore! only the Partners client forced this, and it is unused now. So this PR doesn't really modify that |
Contributor
Author
|
|
isaacroldan
changed the base branch from
deploy-split/05b-deploy-app-version-module
to
graphite-base/8056
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
WHY are these changes introduced?
With the classification module in place (#8055),
deploycan stop using the interactive matching flow.WHAT is this pull request doing?
ensureDeployContextnow callsensureDeployIdentifiersFromAppVersionand returnsDeployIdentifiers.extensionIdsbecomesappModuleRegistrationIds.deployno longer writes identifiers back to the.envfile.The interactive matching flow is now unused; it's removed in #8049.
.env) — needs a changeset.How to test your changes?
pnpm --filter @shopify/app exec vitest run src/cli/services/deploy.test.ts src/cli/services/context.test.ts src/cli/services/deploy/upload.test.ts